Skip to content

Validating the label values against regex #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 3, 2025
Merged

Validating the label values against regex #1345

merged 6 commits into from
Nov 3, 2025

Conversation

@Akshay2191
Copy link
Contributor

@Akshay2191 Akshay2191 commented Oct 16, 2025

Implemented a function to validate the label value against regex to align it with N1C.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@Akshay2191 Akshay2191 requested a review from a team as a code owner October 16, 2025 14:56
@github-actions github-actions bot added the chore Pull requests for routine tasks label Oct 16, 2025
sean-breen
sean-breen reviewed Oct 16, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Oct 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.36%. Comparing base (383ce95) to head (77a5582).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1345      +/-   ##
==========================================
+ Coverage   84.88%   86.36%   +1.48%     
==========================================
  Files         100      102       +2     
  Lines       14520    12519    -2001     
==========================================
- Hits        12325    10812    -1513     
+ Misses       1734     1230     -504     
- Partials      461      477      +16
Files with missing lines Coverage Δ
internal/config/config.go 87.05% <100.00%> (+1.48%) ⬆️

... and 99 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 383ce95...77a5582. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Akshay2191 Akshay2191 requested a review from sean-breen October 16, 2025 18:40
@Akshay2191 Akshay2191 self-assigned this Oct 17, 2025
aphralG
aphralG reviewed Oct 20, 2025
View reviewed changes
sean-breen
sean-breen reviewed Oct 22, 2025
View reviewed changes
@Akshay2191 Akshay2191 merged commit 5d148d9 into main Nov 3, 2025
67 of 68 checks passed
@Akshay2191 Akshay2191 deleted the validate-labels-regex branch November 3, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhurley dhurley dhurley approved these changes

@sean-breen sean-breen sean-breen approved these changes

@spencerugbo spencerugbo spencerugbo approved these changes

@aphralG aphralG Awaiting requested review from aphralG

Assignees

@Akshay2191 Akshay2191

Labels

chore Pull requests for routine tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Akshay2191 @dhurley @sean-breen @spencerugbo @aphralG